[Webkit-unassigned] [Bug 127687] ASSERTION FAILED: !object || (object->isRenderBlock())

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127687





--- Comment #3 from Mihnea Ovidenie <mihnea at adobe.com>  2014-01-30 06:48:47 PST ---
(In reply to comment #2)
> (From update of attachment 222558 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222558&action=review
> 
> > Source/WebCore/rendering/RenderRegion.cpp:110
> >      if (!isValid() || !m_flowThread->firstChild()) // checking for empty region blocks.
> 
> Do we still need this null check on the first child? Why?
> 

The null check on the first child is used to check if the region is attached to a flow thread that has children to be rendered inside the region. If the flow thread does not have such children, we then let the region behave like a normal element without any children.
The new patch will add also a test for this situation - it fails if we take the condition out.

> > Source/WebCore/rendering/RenderRegion.cpp:114
> > -    return toRenderBlock(m_flowThread->firstChild())->positionForPoint(mapRegionPointIntoFlowThreadCoordinates(point));
> > +    LayoutPoint mappedPoint = mapRegionPointIntoFlowThreadCoordinates(point);
> > +    return m_flowThread->positionForPoint(mappedPoint);
> 
> I understand why we are using m_flowThread instead of the first child, but not why this line of code is being broken into two lines of code.
It should not be broken, you are right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.