[Webkit-unassigned] [Bug 127809] REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html are timing out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 29 07:58:18 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127809


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222572|review?                     |review+
               Flag|                            |




--- Comment #4 from Anders Carlsson <andersca at apple.com>  2014-01-29 07:55:41 PST ---
(From update of attachment 222572)
View in context: https://bugs.webkit.org/attachment.cgi?id=222572&action=review

I don't like the "gridSize()" concept, but I can't really think of something better...

> Source/WebCore/rendering/RenderView.cpp:640
> +    static const unsigned maximumRepaintRegionGridSize = 16 * 16;
> +    if (m_accumulatedRepaintRegion->gridSize() > maximumRepaintRegionGridSize)
> +        m_accumulatedRepaintRegion = std::make_unique<Region>(m_accumulatedRepaintRegion->bounds());

I think this could use a comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list