[Webkit-unassigned] [Bug 127816] Web Inspector: [REGRESSION(r162931)] Tab navigation broken in DataGrid

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 28 16:29:20 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127816


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222528|review?                     |review+
               Flag|                            |




--- Comment #3 from Timothy Hatcher <timothy at apple.com>  2014-01-28 16:26:44 PST ---
(From update of attachment 222528)
View in context: https://bugs.webkit.org/attachment.cgi?id=222528&action=review

> Source/WebInspectorUI/UserInterface/DataGrid.js:361
>                      return this._startEditingColumnOfDataGridNode(currentEditingNode, 1);

There are a few 1s and 0s in this function that should also be strings for clarity. Right now they are being converted later into string.

> Source/WebInspectorUI/UserInterface/DataGrid.js:375
>                      return this._startEditingColumnOfDataGridNode(currentEditingNode, 0);

Another 0, but there are more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list