[Webkit-unassigned] [Bug 127722] REGRESSION(r162837): 5% regression on html5-full-render and 3% regression in DoYouEvenBench

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127722


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222466|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2014-01-28 11:19:10 PST ---
(From update of attachment 222466)
View in context: https://bugs.webkit.org/attachment.cgi?id=222466&action=review

> Source/WebCore/dom/Document.cpp:4317
>  Document* Document::topDocument() const
>  {
> -    // FIXME: Why does this walk up owner elements instead using the frame tree as parentDocument does?
> -    // The frame tree even has a top() function.
> -    Document* document = const_cast<Document*>(this);
> -    while (Element* element = document->ownerElement())
> -        document = &element->document();
> -    return document;
> +    return m_frame ? m_frame->mainFrame().document() : const_cast<Document*>(this);
>  }

How is this change related to the rest of the patch? Does something depend on it?

Looks like this never returns null, so it should be changed to return a reference.

> Source/WebCore/rendering/RenderView.h:238
> +    class RepaintRegionAccumulator {

This has no members that are not copyable; we should probably mark it non-copyable explicitly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.