[Webkit-unassigned] [Bug 127671] WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127671


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222303|review?                     |review+
               Flag|                            |




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2014-01-27 19:09:20 PST ---
(From update of attachment 222303)
View in context: https://bugs.webkit.org/attachment.cgi?id=222303&action=review

> Source/WebCore/css/SVGCSSParser.cpp:274
> +        break;

Nice catch!

> Source/WebCore/css/StyleResolver.cpp:2230
> +            return;
>          }
> +        

Ditto!

> Source/WebCore/rendering/AutoTableLayout.cpp:-523
> -            // fall through

Huh, out-dated comment. That's classic.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.