[Webkit-unassigned] [Bug 127675] [EFL][WK2] Add a logic for checking multi touch in GestureRecognizer::noGesture

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 27 17:48:39 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127675





--- Comment #12 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-01-27 17:46:03 PST ---
(From update of attachment 222383)
View in context: https://bugs.webkit.org/attachment.cgi?id=222383&action=review

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:360
> +

Looks unneeded line.

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:364
> +

ditto.

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:374
> +            return;

Why do you use "return" instead of using "break" ?

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:375
> +        default:

Please add ASSERT_NOT_REACHED() to here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list