[Webkit-unassigned] [Bug 127703] Windows tests broken after r162816

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127703


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222374|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2014-01-27 15:53:56 PST ---
(From update of attachment 222374)
View in context: https://bugs.webkit.org/attachment.cgi?id=222374&action=review

> Source/WebCore/ChangeLog:21
> +2014-01-27  Roger Fong  <roger_fong at apple.com>
> +
> +        [Windows] Tests crashing on Windows after r162816.
> +        https://bugs.webkit.org/show_bug.cgi?id=127703.
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * accessibility/AXObjectCache.cpp:
> +        (WebCore::AXObjectCache::enableAccessibility):
> +        (WebCore::AXObjectCache::disableAccessibility):
> +        * accessibility/AXObjectCache.h: Un-inline some methods so that they can be exported.
> +
> +2014-01-27  Roger Fong  <roger_fong at apple.com>
> +
> +        [Windows] Tests crashing on Windows after r162816.
> +        https://bugs.webkit.org/show_bug.cgi?id=127703.
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * testing/Internals.cpp: Initialize gAccessibilityEnabled in WebCoreTestSupport.
> +

Double ChangeLog.

> Source/WebCore/accessibility/AXObjectCache.cpp:112
> +void AXObjectCache::enableAccessibility() { gAccessibilityEnabled = true; }
> +void AXObjectCache::disableAccessibility() { gAccessibilityEnabled = false; };

Please format these as normal multi-line functions, and remove the trailing semicolon.

> Source/WebKit/ChangeLog:4
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).

Yup.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.