[Webkit-unassigned] [Bug 127554] [GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127554





--- Comment #4 from Zan Dobersek <zandobersek at gmail.com>  2014-01-27 07:01:01 PST ---
(From update of attachment 222093)
View in context: https://bugs.webkit.org/attachment.cgi?id=222093&action=review

> Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:188
> +        a.reset();

No need for calling reset() here -- the GUniqueOutPtr will handle freeing the memory when it goes out of scope and is destroyed.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:146
> -    result.clear();
> +    result.reset();

No need for calling reset() here (since the unique pointer will be reset when outPtr() is called the next time) ...

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:168
> -    result.clear();
> +    result.reset();

... or here (since the pointer will be deleted when GUniqueOutPtr goes out of scope).

I guess GUniqueOutPtr is now smart enough that the user doesn't really have to know about the reset() method, so it can be made private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.