[Webkit-unassigned] [Bug 125463] [GTK] Add API to allow setting the process model in WebKitWebContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125463





--- Comment #20 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-27 00:45:51 PST ---
(From update of attachment 222275)
View in context: https://bugs.webkit.org/attachment.cgi?id=222275&action=review

This looks great to me. We need the approval from another WebKitGTK+ reviewer, since this introduces new public API.

> Source/WebKit2/ChangeLog:10
> +        used. Setting WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES

WEBKIT_PROCESS_MODEL_SECONDARY_PROCESS_PER_WEB_VIEW

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:895
> +static_assert(WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS == ProcessModelSharedSecondaryProcess,
> +    "ProcessModel and WebKitProcessModel enum values do not have the same integral value");
> +static_assert(WEBKIT_PROCESS_MODEL_SECONDARY_PROCESS_PER_WEB_VIEW == ProcessModelMultipleSecondaryProcesses,
> +    "ProcessModel and WebKitProcessModel enum values do not have the same integral value");

We have macros for this, see COMPILE_ASSERT_MATCHING_ENUM in WebKitPrivate.h

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:910
> + * %WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES to use one auxiliary

WEBKIT_PROCESS_MODEL_SECONDARY_PROCESS_PER_WEB_VIEW

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:925
> +        context->priv->context->setUsesNetworkProcess(processModel == ProcessModelMultipleSecondaryProcesses);

We should probably remove the WEBKIT_USE_NETWORK_PROCESS env var.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:70
> + *   #WebKitWebView instances created by the application. If the secondary
> + *   This is the default process model, and it should suffice for most cases.

If the secondary This is the default?

> Tools/MiniBrowser/gtk/main.c:244
> +    const gchar *multiprocess= g_getenv("MINIBROWSER_MULTIPROCESS");

multiprocess= -> multiprocess =

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:27
> +class MultiprocessTest;

Why do you need this?

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:35
> +

Remove tis empty line.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:105
> +    test->loadWebViewAndWaitUntilLoaded(0);
> +    g_assert(WEBKIT_IS_WEB_VIEW(test->m_webViews[0].get()));
> +    g_assert(test->m_webViewBusNames[0]);
> +
> +    test->loadWebViewAndWaitUntilLoaded(1);
> +    g_assert(WEBKIT_IS_WEB_VIEW(test->m_webViews[1].get()));
> +    g_assert(test->m_webViewBusNames[1]);

Now that I see this, I guess we can use a for loop.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.