[Webkit-unassigned] [Bug 127613] Web Inspector: In a DataGrid, store value of columnIdentifier to DOM node representing a cell

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127613


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222234|review?                     |review+
               Flag|                            |




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-25 16:49:59 PST ---
(From update of attachment 222234)
View in context: https://bugs.webkit.org/attachment.cgi?id=222234&action=review

r=me

> Source/WebInspectorUI/UserInterface/DataGrid.js:156
> +        td.columnIdentifier = columnIdentifier;

As Tim suggested, we should use "__columnIdentifier".

We typically use "__foo" syntax for property names when one class is storing properties on another object, and that other object has no knowledge of the existence of that property. Though ".columnIdentifier" works, it is not immediately clear if you're debugging this element that the property is something we injected onto the element. And having it show up as obvious in the debugger can sometimes be helpful! Also, if in the further that object wanted to add a "columnIdentifier" property then the double underscore would avoid a naming conflict.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.