[Webkit-unassigned] [Bug 127613] Web Inspector: In a DataGrid, store value of columnIdentifier as a dataset attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127613





--- Comment #4 from Timothy Hatcher <timothy at apple.com>  2014-01-25 09:36:38 PST ---
(From update of attachment 222197)
View in context: https://bugs.webkit.org/attachment.cgi?id=222197&action=review

I agree with Joe. We need the className for style reasons. I am also not a fan of dataset. There is no reason to use a DOM attribute for internal logic. I would just set cell.__columnIdentifier and use it later.

> Source/WebInspectorUI/UserInterface/DataGrid.js:903
> -                // The first child of the selected element is the <td class="0-column">,
> +                // The first child of the selected element is the <td data-columnIdentifier="0">,

The original comment is not correct, the column identifier is not usually a number, it is a arbitrary string. Just remove this comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.