[Webkit-unassigned] [Bug 127615] Web Inspector: Position the completion suggestions popup below if there is room

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127615


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222199|review?                     |review+
               Flag|                            |




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-25 09:35:06 PST ---
(From update of attachment 222199)
View in context: https://bugs.webkit.org/attachment.cgi?id=222199&action=review

Nice! r=me with some style nits.

> Source/WebInspectorUI/ChangeLog:6
> +        Web Inspector: Position the completion suggestions popup below if
> +        there is room enough.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=127615

Style: `./Tools/Scripts/prepare-ChangeLog -b 127615` would not wrap the title line and would put the bugzilla bug on the next line without an empty line between.

> Source/WebInspectorUI/UserInterface/CompletionSuggestionsView.js:153
> +        // Position the suggestions below the anchor. If there is no room, position the suggestions above

Style: Comments in WebKit are full sentences. This second sentence should end in a period.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.