[Webkit-unassigned] [Bug 127091] [GTK] Implement custom URI schemes with CustomProtocols

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127091





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-24 23:36:12 PST ---
(In reply to comment #6)
> (From update of attachment 221985 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221985&action=review
> 
> Is this holding something back? I guess we should figure out how to reimplement obtaining the originating webview or land this after we branch? LGTM otherwise.

Yes, we need to find a solution for the initiating web view :-(

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:943
> > -void webkitWebContextReceivedURIRequest(WebKitWebContext* context, WebKitURISchemeRequest* request)
> > +void webkitWebContextStartLoadingCustomProtocol(WebKitWebContext* context, uint64_t customProtocolID, API::URLRequest* urlRequest)
> >  {
> > -    String scheme(String::fromUTF8(webkit_uri_scheme_request_get_scheme(request)));
> > +    // FIXME: We need to figure out how to get the initiating page.
> 
> Is customProtocolID unique per requested load, or is that an id for the scheme? We could maintain a mapping of those IDs to pages, I guess.

It's per request, yes, but it's generated by the networking process, and at this point in the web context we don't know the web view associated to this request ID to make a map.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.