[Webkit-unassigned] [Bug 127605] Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127605





--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-24 22:12:31 PST ---
> 
> > Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp:2
> > + * Copyright (C) 2013 Apple Inc. All rights reserved.
> 
> 2014

Hehe, good catch on these. I had written this in 2013 though, I didn't copy/paste error it =). I'll update them.


> > Source/WebCore/inspector/PageRuntimeAgent.cpp:56
> > +PageRuntimeAgent::PageRuntimeAgent(InjectedScriptManager* injectedScriptManager, Page* page, InspectorPageAgent* pageAgent)
> 
> We might want to consider putting Inspector back in these subclass names. Page or Web?

Names could get ridiculously long. Lets keep these JSGlobalObject/Web/Page/Worker. And if we need to change we can change all at once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.