[Webkit-unassigned] [Bug 127605] Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127605


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222189|review?                     |review+
               Flag|                            |




--- Comment #5 from Timothy Hatcher <timothy at apple.com>  2014-01-24 21:05:59 PST ---
(From update of attachment 222189)
View in context: https://bugs.webkit.org/attachment.cgi?id=222189&action=review

> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2013, 2014?

> Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014

> Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014

> Source/WebCore/inspector/PageRuntimeAgent.cpp:56
> +PageRuntimeAgent::PageRuntimeAgent(InjectedScriptManager* injectedScriptManager, Page* page, InspectorPageAgent* pageAgent)

We might want to consider putting Inspector back in these subclass names. Page or Web?

> Source/WebCore/inspector/PageRuntimeAgent.h:70
> +    virtual JSC::VM* globalVM() override;

final too?

> Source/WebCore/inspector/WorkerRuntimeAgent.h:59
> +    virtual JSC::VM* globalVM() override;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.