[Webkit-unassigned] [Bug 127091] [GTK] Implement custom URI schemes with CustomProtocols

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127091





--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2014-01-24 06:34:29 PST ---
(From update of attachment 221985)
View in context: https://bugs.webkit.org/attachment.cgi?id=221985&action=review

Is this holding something back? I guess we should figure out how to reimplement obtaining the originating webview or land this after we branch? LGTM otherwise.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:943
> -void webkitWebContextReceivedURIRequest(WebKitWebContext* context, WebKitURISchemeRequest* request)
> +void webkitWebContextStartLoadingCustomProtocol(WebKitWebContext* context, uint64_t customProtocolID, API::URLRequest* urlRequest)
>  {
> -    String scheme(String::fromUTF8(webkit_uri_scheme_request_get_scheme(request)));
> +    // FIXME: We need to figure out how to get the initiating page.

Is customProtocolID unique per requested load, or is that an id for the scheme? We could maintain a mapping of those IDs to pages, I guess.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.