[Webkit-unassigned] [Bug 127409] Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127409





--- Comment #16 from Geoffrey Garen <ggaren at apple.com>  2014-01-23 12:25:47 PST ---
> If you're debugging a JSContext/JSContextRef this would mean the JSGlobalObject is being destroyed.
> If you're debugging a WebCore::Page, this would mean the WebCore::Page is closing.

Got it.

> I think "InspectedObject..." better satisfies both of these and potential future inspector debuggable targets.
> 
> I'm open to other naming suggestions. Would you prefer "InspectedObjectClosed"?

Hmmm... no, I guess "closed" is not great, since, in the JSContext case you pointed out, nothing got "closed".

I guess what we're trying track is which side will be destroyed. If the inspector will be destroyed, it needs to put the inspected thingy back to normal; if the inspected thingy will be destroyed, well, that's the end of that, and there's nothing to put back to normal.

How about:
InspectorDestroyed
InspectedObjectDestroyed

Even though "object" is still a bit abstract, hopefully similar phrasing will highlight the contrast between "Inspector" and "InspectedObject".

Anyway, I'll leave the final decision up to you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.