[Webkit-unassigned] [Bug 127409] Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 11:46:09 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127409





--- Comment #15 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-23 11:43:38 PST ---
(In reply to comment #14)
> (From update of attachment 221932 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221932&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/inspector/InspectorAgentBase.h:38
> > +    InspectedObjectBeingDestroyed,
> 
> Can we be a little more specific here? Based on your comment below, how about "InspectedPageClosed"?

If you're debugging a JSContext/JSContextRef this would mean the JSGlobalObject is being destroyed.
If you're debugging a WebCore::Page, this would mean the WebCore::Page is closing.

I think "InspectedObject..." better satisfies both of these and potential future inspector debuggable targets.

I'm open to other naming suggestions. Would you prefer "InspectedObjectClosed"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list