[Webkit-unassigned] [Bug 127469] [GTK] Avoid unnecessary string duplications in FileSystemGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127469





--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2014-01-23 09:12:23 PST ---
(From update of attachment 221964)
View in context: https://bugs.webkit.org/attachment.cgi?id=221964&action=review

You're right. I neglected to notice that fileSystemRepresentation was converting from a c string into a CString.

> Source/WebCore/platform/gtk/FileSystemGtk.cpp:62
> +    if (path.isEmpty())
> +        return nullptr;
> +    return GUniquePtr<char>(g_uri_unescape_string(path.utf8().data(), nullptr));
> +}

This doesn't appear to be doing the right thing for Windows. In Windows we just need to return path.utf8() to maintain the current behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.