[Webkit-unassigned] [Bug 127469] [GTK] Avoid unnecessary string duplications in FileSystemGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127469





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-23 06:28:27 PST ---
(In reply to comment #5)
> (From update of attachment 221956 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221956&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        We are using fileSystemRepresentation() everywhere internally
> > +        which returns a CString that always duplicates the string.
> > +        Add unescapedFilename() internal helper function that returns a
> > +        GUniquePtr and used it everywhere instead of fileSystemRepresentation().
> 
> I'm not sure this is true. CStrings contain a reference-counted internal buffer.

The constructor always allocates memory and copies the given string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.