[Webkit-unassigned] [Bug 127469] [GTK] Avoid unnecessary string duplications in FileSystemGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 06:17:18 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127469





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2014-01-23 06:14:47 PST ---
(From update of attachment 221956)
View in context: https://bugs.webkit.org/attachment.cgi?id=221956&action=review

> Source/WebCore/ChangeLog:11
> +        We are using fileSystemRepresentation() everywhere internally
> +        which returns a CString that always duplicates the string.
> +        Add unescapedFilename() internal helper function that returns a
> +        GUniquePtr and used it everywhere instead of fileSystemRepresentation().

I'm not sure this is true. CStrings contain a reference-counted internal buffer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list