[Webkit-unassigned] [Bug 127472] Add ARM EFL Linux builder bot to Apple buildmaster

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127472





--- Comment #2 from Csaba Osztrogonác <ossy at webkit.org>  2014-01-23 04:14:44 PST ---
(From update of attachment 221970)
View in context: https://bugs.webkit.org/attachment.cgi?id=221970&action=review

The patch looks good to me in general, but I I have some nit-picks:

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:45
> +                    { "name": "efl-linux-slave-4", "platform": "efl" }

It would be better to have a name refer to this slave is hosted by University of Szeged.
for example: szeged-slave-1

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:189
> +                      "name": "EFL Linux ARMv7 Release (Build)", "type": "Build", "builddir": "efl-linux-armv7-release",

Is this bot use ARM or Thumb2 instruction set?
I think the name of the bot should say it:
"EFL Linux ARMv7 Thumb2 Release (Build)" or 
"EFL Linux ARMv7 Traditional Release (Build)"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.