[Webkit-unassigned] [Bug 127469] [GTK] Avoid unnecessary string duplications in FileSystemGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127469





--- Comment #2 from Sergio Villar Senin <svillar at igalia.com>  2014-01-23 01:28:37 PST ---
(From update of attachment 221956)
View in context: https://bugs.webkit.org/attachment.cgi?id=221956&action=review

Looks good to me but your changes unveil an already existing bug. See inline...

> Source/WebCore/platform/gtk/FileSystemGtk.cpp:84
> +    GUniquePtr<gchar> display(g_filename_to_utf8(filename.get(), 0, nullptr, nullptr, nullptr));

This definitely sounds like a bug to me. We're passing 0 as the string length. We should either use -1 if null terminated or the actual string length if known.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.