[Webkit-unassigned] [Bug 127431] [GLIB] Use GUniquePtr instead of GOwnPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127431





--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-22 23:46:04 PST ---
(In reply to comment #10)
> (From update of attachment 221876 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221876&action=review
> 
> This is a very large patch, but appears to be largely mechanical.

Yeah, thanks for the quick review.

> > Source/WebCore/platform/network/soup/GUniquePtrSoup.h:2
> > + *  Copyright (C) 2010 Igalia S.L
> 
> Probably want to use 2014 here.

Sure.

> > Source/WebCore/platform/network/soup/GUniquePtrSoup.h:24
> > +#include <libsoup/soup.h>
> > +#include <wtf/gobject/GUniquePtr.h>
> 
> One disadvantage of this is that we include third-party headers in more places, so this has the potential to impact compilation time. I suppose that isn't a *huge* issue though.

Yes, I thought about that too, the advantage is that you can use those just including the header. I haven't noticed any regression in the build time, but I'll check if we can improve it anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.