[Webkit-unassigned] [Bug 127431] [GLIB] Use GUniquePtr instead of GOwnPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127431


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221876|review?                     |review+
               Flag|                            |




--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2014-01-22 17:28:57 PST ---
(From update of attachment 221876)
View in context: https://bugs.webkit.org/attachment.cgi?id=221876&action=review

This is a very large patch, but appears to be largely mechanical.

> Source/WebCore/platform/network/soup/GUniquePtrSoup.h:2
> + *  Copyright (C) 2010 Igalia S.L

Probably want to use 2014 here.

> Source/WebCore/platform/network/soup/GUniquePtrSoup.h:24
> +#include <libsoup/soup.h>
> +#include <wtf/gobject/GUniquePtr.h>

One disadvantage of this is that we include third-party headers in more places, so this has the potential to impact compilation time. I suppose that isn't a *huge* issue though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.