[Webkit-unassigned] [Bug 125006] [curl] Improve detecting and handling of SSL client certificate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125006


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221843|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org>  2014-01-22 09:47:53 PST ---
(From update of attachment 221843)
View in context: https://bugs.webkit.org/attachment.cgi?id=221843&action=review

Thanks for revising!  Looks great.

> Source/WebCore/platform/network/curl/SSLHandle.cpp:59
> +    HashMap<String, clientCertificate>::iterator it = allowedClientHosts.find(host.lower());

In the future, consider using auto. I think this could be a const_iterator, or even better "const auto& it = ..."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.