[Webkit-unassigned] [Bug 127337] Fix SVG animations which set rx or ry attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127337





--- Comment #5 from Philip Rogers <pdr at google.com>  2014-01-21 19:06:04 PST ---
(In reply to comment #4)
> (From update of attachment 221730 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221730&action=review
> 
> > Source/WebCore/rendering/svg/SVGPathData.cpp:119
> > +    bool hasRx = rect->rx().value(lengthContext) > 0;
> > +    bool hasRy = rect->ry().value(lengthContext) > 0;
> 
> Wasteful to repeat these expressions once to evaluate the has booleans and a second time if either is true. Should refactor so we don’t do it twice.

Excellent catch Darin. We should definitely refactor that into a helper function.

> 
> Also, is > 0 really the correct test? Is that from the spec, or just copying what the Blink folks did? Did the Blink folks give a rationale for that particular test?

The Blink folks did a terrible job of describing this change and I apologize for that :(
The spec is clear about negative rx/ry values in https://svgwg.org/svg2-draft/single-page.html#shapes-RectElement, and the new behavior matches Firefox (IE does not support SMIL). This change is really about making the negative rx/ry logic work for animations as well. The hasAttribute check is not appropriate for attributes that can be set by an animation element.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.