[Webkit-unassigned] [Bug 127169] If not running on Mac, build-webkit should not print Safari related output

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127169





--- Comment #3 from Éva Balázsfalvi <balazsfalvi.eva at stud.u-szeged.hu>  2014-01-21 02:38:24 PST ---
(In reply to comment #2)

Thank you for your feedback.

> Mac is not an acronym. It's shorthand for Macintosh.
> if ($launcherPath && $launcherName) { ... }

Thanks for noticing, you were absolutely right. I've modified the code.

>> Tools/Scripts/webkitdirs.pm:1290
>> +    } elsif (isDarwin()) {

>Can you elaborate on this change?

isAppleWebKit() gives back a value depending on the values of isGtk(), isEfl(), isWinCE(), isNix(). If we're using the script without any switch, each of these fuctions will give back a false value. But because of this, isAppleWebKit() will return as true, regardless of where we were running the script. This is why the Safari related output was given. isDarwin()'s value doesn't depend on any of the previously mentioned functions, that is why I thought it might be a good idea to use it instead of isAppleWebKit().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.