[Webkit-unassigned] [Bug 121694] Assertion failure in Range::nodeWillBeRemoved

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121694





--- Comment #14 from László Langó <llango.u-szeged at partner.samsung.com>  2014-01-20 04:20:36 PST ---
(In reply to comment #13)
> (From update of attachment 221643 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221643&action=review
> 
> > Source/WebCore/dom/ContainerNode.cpp:491
> > +    if (child.parentNode() != this)
> 
> Question: Should willRemoveChildren be patched as well? It's a similar function processing a list of nodes.

Good question. I don't see any connection between Range::nodeWillBeRemoved() and willRemoveChildren functions. And there is no ASSERT(node->parentNode()); in Range::nodeChildrenWillBeRemoved. I don't no is that a problem or not, but I see your point. To be honest, I think Range::nodeChildrenWillBeRemoved should call Range::nodeWillBeRemoved(), if it can, because that would be more readable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.