[Webkit-unassigned] [Bug 108184] ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108184





--- Comment #13 from Tamas Gergely <tgergely.u-szeged at partner.samsung.com>  2014-01-20 01:18:12 PST ---
(In reply to comment #12)
> (From update of attachment 221467 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221467&action=review
> 
> This looks good to me. One minor issue with the test.
> 
> > LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:14
> > +            document.getElementById("label").textContent = "SMILElement animation time self-dependency is" +
> 
> Why not end the test here?
> 
> You can do:
> document.write("SMILElement animation ... etc");
> if (testRunner)
>     testRunner.notifyDone();

Here we want to test whether self-dependency is correctly handled. If you just write out a fixed string, it will test whether WK crashes in the case of self-dependency, but it will not find situations where the self-dependency is silently dropped (e.g. my first try).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.