[Webkit-unassigned] [Bug 108184] ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108184


Philip Rogers <pdr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221467|review?                     |review+
               Flag|                            |




--- Comment #12 from Philip Rogers <pdr at google.com>  2014-01-17 13:29:02 PST ---
(From update of attachment 221467)
View in context: https://bugs.webkit.org/attachment.cgi?id=221467&action=review

This looks good to me. One minor issue with the test.

> LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:14
> +            document.getElementById("label").textContent = "SMILElement animation time self-dependency is" +

Why not end the test here?

You can do:
document.write("SMILElement animation ... etc");
if (testRunner)
    testRunner.notifyDone();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.