[Webkit-unassigned] [Bug 127169] If not runned on MAC, "Tools/Scripts/build-webkit" should not post Safari related informations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127169


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221463|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Daniel Bates <dbates at webkit.org>  2014-01-17 09:55:20 PST ---
(From update of attachment 221463)
View in context: https://bugs.webkit.org/attachment.cgi?id=221463&action=review

> Tools/ChangeLog:3
> +        If not runned on MAC, "Tools/Scripts/build-webkit" should not post Safari related informations

Nit: MAC => Mac

Mac is not an acronym. It's shorthand for Macintosh.

> Tools/Scripts/build-webkit:431
> +    if ($launcherPath ne "0" && $launcherName ne "0") {

Without loss of generality, take $launcherName to be undefined (say launcherName() falls off the end of the function) then evaluating the condition of this if statement will cause an uninitialized value warning because we run this script with -w (see the first line in this script). Moreover, it seems weird to define "0" as an invalid value and compare to it. It's sufficient to look at the truth value of the variables:

if ($launcherPath && $launcherName) {
   ...
}

> Tools/Scripts/webkitdirs.pm:1290
> +    } elsif (isDarwin()) {

Can you elaborate on this change?

> Tools/Scripts/webkitdirs.pm:1305
> +    } elsif (isDarwin()) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.