[Webkit-unassigned] [Bug 127014] AnimationController: replace animation timer with compositor-driven mechanism

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127014





--- Comment #17 from WebKit Commit Bot <commit-queue at webkit.org>  2014-01-16 13:59:13 PST ---
Attachment 221412 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/AnimationControllerPrivate.h', u'Source/WebCore/page/animation/AnimationTimer.cpp', u'Source/WebCore/page/animation/AnimationTimer.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:28:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:28:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:38:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:44:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:54:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:55:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:59:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.cpp:76:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.h:32:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.h:52:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/page/animation/AnimationTimer.h:53:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.h:78:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/page/animation/AnimationTimer.h:108:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/page/FrameView.cpp:2608:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 16 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.