[Webkit-unassigned] [Bug 108184] ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108184


Philip Rogers <pdr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221344|review?                     |review-
               Flag|                            |




--- Comment #8 from Philip Rogers <pdr at google.com>  2014-01-16 11:38:53 PST ---
(From update of attachment 221344)
View in context: https://bugs.webkit.org/attachment.cgi?id=221344&action=review

Almost there! Just a few minor issues with the test.

> LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:13
> +        if (window.testRunner) {

I'm confused... this will fire and stop the test before the settimeouts below even trigger.

> LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:18
> +        setTimeout('displayMessage()', 500);

This timeout is much too large. Can you try either 0 or, worst case, 30-40? You can use document.documentElement.setCurrentTime to set the current time so you don't have to wait for the animation to advance.

We have 20,000 tests and we try very hard to keep them as fast as possible. Because this test will exist on the tree for years to come, it's important to ensure it's as fast as we can make it.

> LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:21
> +            setTimeout('testRunner.notifyDone()', 600);

Same here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.