[Webkit-unassigned] [Bug 126133] Make CachedSVGDocument independent of CSS Filters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126133


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221144|review?                     |review+
               Flag|                            |




--- Comment #17 from Antti Koivisto <koivisto at iki.fi>  2014-01-14 06:47:09 PST ---
(From update of attachment 221144)
View in context: https://bugs.webkit.org/attachment.cgi?id=221144&action=review

r=me

> Source/WebCore/css/StyleResolver.cpp:3433
> +    for (auto it = state.pendingSVGDocuments().begin(), end = state.pendingSVGDocuments().end(); it != end; ++it)
> +        (*it)->load(cachedResourceLoader);

Please use range-for syntax:

for (auto pendingDocument : state.pendingSVGDocuments())

> Source/WebCore/loader/cache/CachedSVGDocumentReference.h:44
> -    CachedSVGDocumentReference(CachedSVGDocument*);
> +    static std::unique_ptr<CachedSVGDocumentReference> create(const String& url)
> +    {
> +        return std::unique_ptr<CachedSVGDocumentReference>(new CachedSVGDocumentReference(url));
> +    }

No need to add create(). Please just keep the constructor public and use std::make_unique<CachedSVGDocumentReference>(url);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.