[Webkit-unassigned] [Bug 115640] Text should be constructable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 14 00:22:55 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=115640





--- Comment #10 from László Langó <llango.u-szeged at partner.samsung.com>  2014-01-14 00:20:32 PST ---
(In reply to comment #9)
> (From update of attachment 221026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221026&action=review
> 
> > Source/WebCore/dom/Text.h:39
> > +    static PassRefPtr<Text> create(ScriptExecutionContext&, const String&);
> 
> Why ScriptExecutionContext? This always need to be a Document.

Basically because this is how in the Blink did it. :) https://chromium.googlesource.com/chromium/blink/+/cdd5a914daf3862379a5ce4596149bd690d0fa08

I'm not sure I fully understand, but we have only this in bindings/scripts/IDLAttributes (ConstructorCallWith=ScriptExecutionContext). A don't think that this is a problem, because we can safely convert it into a document with the toDocument function. Do you know another equivalent way how can we do this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list