[Webkit-unassigned] [Bug 126818] Add AVKit fullscreen video interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126818





--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2014-01-12 10:48:10 PST ---
(From update of attachment 220941)
View in context: https://bugs.webkit.org/attachment.cgi?id=220941&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:247
> +    self.loadedTimeRanges = @[ @0, @(duration) ];

We don't always have the entire file loaded. minTimeSeekable() and maxTimeSeekable() are probably what you want. This is probably fine for the initial patch, but please file a bug to fix it and include a "FIXME:" here that references the bug.

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:275
> +        self.maxTime = duration;

Is maxTime the maximum time loaded or the maximum time seekable? In either case, this isn't correct. Please file a bug and reference it here if you aren't going to fix it in this patch.

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:280
> +        self.loadedTimeRanges = @[
> +            @0,
> +            @(duration)
> +        ];

Ditto the comment about loadedTimeRanges above.

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:305
> +    if ((self = [super init])) {

if (!(self = [super init]))
        return nil;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.