[Webkit-unassigned] [Bug 126577] [SOUP] [WK2] - Disable MemoryCache when the DOCUMENT_VIEWER cache model is set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126577





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-12 01:23:57 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > In r152483 we also check that cacheTotalCapacity is 0, don't we need that in wk2 as well?
> 
> Actually the calculateCacheSizes will return != 0 for cacheTotalCapacity even for WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER. Another solution will be just asking straight for cache model.

Yes, in the end what we want is to make sure that memory cache is disabled for DocumentViewer cache model, because that's what our public API documentation says. So, I would do something like this:

#if PLATFORM(GTK)
WebCore::memoryCache()->setDisabled(cacheModel == CacheModelDocumentViewer);
#endif

It's also more obvious and it's the only model that returns cacheMinDeadCapacity = cacheMaxDeadCapacity = 0 after all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.