[Webkit-unassigned] [Bug 126692] [GStreamer] Playback rate is not set when pipeline is not ready.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126692





--- Comment #4 from Philippe Normand <pnormand at igalia.com>  2014-01-11 18:21:17 PST ---
(From update of attachment 220827)
View in context: https://bugs.webkit.org/attachment.cgi?id=220827&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:638
> +    if (m_changingRate) {

Can this be changed to an early return please?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1473
> +    if (getStateResult == GST_STATE_CHANGE_SUCCESS && (state == GST_STATE_PAUSED || state == GST_STATE_PLAYING)) {

the second test could be simplified to state >= GST_STATE_PAUSED

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.