[Webkit-unassigned] [Bug 119513] [WebGL] compileShader map iterator validation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 10 10:35:33 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=119513


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #208172|review?                     |review-
               Flag|                            |




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org>  2014-01-10 10:33:15 PST ---
(From update of attachment 208172)
This patch isn't necessary (though it would be harmless).

We call "m_extensions->getTranslatedShaderSourceANGLE(shader)", which does it's own check of the m_shaderSourceMap, and returns an empty string if there is no shader source entry. We check for the empty string and return prior to hitting the point where you propose adding a check.

I don't think this change would actually be executed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list