[Webkit-unassigned] [Bug 125000] [WebGL] Wrong condition order in the if statement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125000


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218042|review?                     |review-
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2014-01-09 19:34:52 PST ---
(From update of attachment 218042)
View in context: https://bugs.webkit.org/attachment.cgi?id=218042&action=review

You are right!  Let's clean the change log up slightly and get this landed.

> Source/WebCore/ChangeLog:3
> +        [WebGL] Wrong condition order in the if statement

[WebGL] Revise condition order for better performance

> Source/WebCore/ChangeLog:12
> +        this method.

Please Rephrase: We should revise the logic so that we only pay the cost of string comparison once.  The current logic causes the string comparison to happen every time we enter this function. Instead, by reordering the statements we can do a simple boolean test after the initial setup is complete.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.