[Webkit-unassigned] [Bug 126689] Move platformName property from testRunner to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126689





--- Comment #4 from chris fleizach <cfleizach at apple.com>  2014-01-09 10:27:24 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 220710 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=220710&action=review
> > 
> > > Tools/ChangeLog:12
> > > +        gtk, efl) but between platofms (atk, mac, win).
> > 
> > platofrms -> platforms
> 
> Ok.
> 
> > > Tools/DumpRenderTree/AccessibilityController.cpp:161
> > > +#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN) || PLATFORM(EFL)
> > 
> > is there any platform that doesn't want this?
> > seems like we prob don't need the #if check
> 
> I thought the same, but then I though of the IOS version of AccessibilityController (all guarded with #if PLATFORM(IOS)) and it was not clear to me whether I should added there, and also what to report as the platform name ("mac"? "ios"?)
> 
> If you can clarify this, I'm happy to include the related bits in AccessibilityControllerIOS and get rid of all these checks here

Yes, let's add it to iOS as well

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.