[Webkit-unassigned] [Bug 126130] [GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126130





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-01-09 09:44:23 PST ---
(In reply to comment #3)
> (From update of attachment 220072 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220072&action=review
> 
> > Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:80
> > +// This function is based on Epiphany code in ephy-embed-prefs.c.
> > +static CString buildAcceptLanguages(Vector<String> languages)
> 
> Looking around, it seems that ephy-embed-prefs.c is GPL which is a big no-no. Maybe you can get Xan to relicense it since he seems to be the only copyright holder.

It's true that the code was copied from ephy and then adapted to wk coding style, but the original code in ephy (which is not part of ephy anymore since it's wk2 only) was copied from libsoup, that is LGPL. Dan, could you confirm that piece of code is LGPL? I'll update the comment (or just remove it) to avoid confusions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.