[Webkit-unassigned] [Bug 126684] Switch HTMLTableRowsCollection from Traversal<> to iterators

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 9 07:47:36 PST 2014


--- Comment #6 from Darin Adler <darin at apple.com>  2014-01-09 07:45:18 PST ---
(From update of attachment 220705)
View in context: https://bugs.webkit.org/attachment.cgi?id=220705&action=review

>>> Source/WebCore/dom/ElementChildIterator.h:160
>>> +        return end();
>> If this element is a child of m_parent, just not the correct type, I would expect this function to return the next child of the correct type if any, not always end().
>> A way to avoid this problem entirely would be to make the argument be ElementType& instead of const Element&.
> I guess I’m wrong. We are using end() here as a sort of null value.
> But I do think that we should have a find that takes the specific element type to avoid the runtime isElementOfType check.

I guess I really don’t like find for the name of this. It sounds like something that iterates the children, when really it’s just a sort of alternate iterator constructor.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list