[Webkit-unassigned] [Bug 126604] Add bots for CLoop build and test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 8 08:27:56 PST 2014


--- Comment #4 from Csaba Osztrogonác <ossy at webkit.org>  2014-01-08 08:25:40 PST ---
(From update of attachment 220557)
View in context: https://bugs.webkit.org/attachment.cgi?id=220557&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:843
> +    LayoutTestClass = RunCLOOPTests

Something is bad here, the bot runs jsc tests twice and without cloop.

- first run: step 6, perl ./Tools/Scripts/run-javascriptcore-tests --debug (It rebuilds the non cloop JSC!!!)
- second run: step 7, perl ./Tools/Scripts/run-javascriptcore-tests --cloop --no-build --no-jsc-stress --debug

Maybe we should add a JSCTestClass to BuildAndTestFactory and RunCLOOPTests 
(why not RunCLoopTests) could be inherited from RunJavascriptCoreTests and 
simple add the extra --cloop and --no-jsc-stress-test options.

And we could avoid compiling with using None CompileClass with adding
a null check in BuildAndTestFactory for it similar to LayoutTestClass.

(Otherwise many thanks for this cloop bot, it was a very good idea.)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list