[Webkit-unassigned] [Bug 126571] [WK2][Gtk] Add support for ENABLE_INSPECTOR_SERVER to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126571





--- Comment #12 from Zan Dobersek <zandobersek at gmail.com>  2014-01-08 01:26:53 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > I don't expect web developers to build their own version of webkit just to have remote inspector enabled. The remote inspector needs to be enabled at run time, it's not working unless an env variable is present, so I think it's harmless having it always built, and the benefit is huge.
> in that case ,it is ok and now i am enabling default yes to remote web inspector, during build time we can decide to disable if requires for any case

Configuration flags are reserved for features that introduce extra dependencies, for instance spellchecking, HTML5 multimedia support, Web Audio etc.

Remote inspector support doesn't introduce any new dependencies, and can be disabled at runtime. Because of that there's no need for an extra configuration flag -- the feature should be enabled at build-time.

The only thing I'd recommend changing is to move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4 and define it to 1 unconditionally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.