[Webkit-unassigned] [Bug 126598] Web Inspector: Move InjectedScript classes into JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126598





--- Comment #22 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-07 15:58:13 PST ---
(From update of attachment 220562)
View in context: https://bugs.webkit.org/attachment.cgi?id=220562&action=review

>> Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:85
>> +
> 
> Because you have a non-trivial destructor, I believe you need this in the class definition:
> 
>     static const bool needsDestruction = true;
> 
> You should set a breakpoint on this function and verify that it is actually called.

Good find! I had tested this worked as expected when I was inspecting a JSContext but I'll add this and verify when debugging a Page and make sure I didn't regress anything there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.