[Webkit-unassigned] [Bug 126553] createElementNS does not handle 'xmlns' name correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126553





--- Comment #11 from Victor Costan <costan at gmail.com>  2014-01-07 12:53:20 PST ---
(In reply to comment #9)
> (From update of attachment 220494 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220494&action=review
> 
> > LayoutTests/fast/dom/createElementNS-namespace-errors.html:10
> > +shouldThrow("document.createElementNS(null, 'foo:bar', 'baz')", '"Error: NamespaceError: DOM Exception 14"');
> 
> Might be a stupid question... What is the third argument in all the tests?

It's just a proof that I copy-pasted the tests I used in setAttributeNS. Sorry and thank you for catching that!

> 
> > LayoutTests/fast/dom/createElementNS-namespace-errors.html:18
> > +shouldNotThrow("document.createElementNS('http://www.w3.org/2000/xmlns/', 'xmlns', 'http://wwww.example.org')");
> > +shouldThrow("document.createElementNS('http://www.w3.org/2000/not-xmlns/', 'xmlns', 'http://wwww.example.org')", '"Error: NamespaceError: DOM Exception 14"');
> 
> Might be nice to test for what elements these actually create, not just whether they raise exceptions or not. That's far from obvious, I think.

Done. Can you please take a look and tell me if this is what you had in mind?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.