[Webkit-unassigned] [Bug 126571] [WK2][Gtk] Add support for ENABLE_INSPECTOR_SERVER to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126571





--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2014-01-07 09:53:48 PST ---
(From update of attachment 220514)
View in context: https://bugs.webkit.org/attachment.cgi?id=220514&action=review

Seems fine to me. I'll let a GTK developer review in the end though.

> Source/WebKit2/ChangeLog:1
> +2014-01-07  jay bhaskar  <jay.bhaskar at samsung.com>

Nit: Is your name normally lowercase, or capitalized? Jay Bhaskar?

I believe prepare-ChangeLog uses the REAL_NAME environment variable.

> Source/WebKit2/ChangeLog:4
> +        patch enables build system to disable/enable inspector server
> +        https://bugs.webkit.org/show_bug.cgi?id=126571

Nit: This should match the format of the other ChangeLog. Essentially what `prepare-ChangeLog -b 126571` would have given you.

> Source/autotools/ReadCommandLineArguments.m4:237
> +            AC_HELP_STRING([--enable-inspector-server], [build Remote Web Inspector for WebKit2 [default=no]]),
> +                           [], [enable_inspector_server="no"])

Nit: Formatting here is harder to read then all the others.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.