[Webkit-unassigned] [Bug 126055] #defined constants should use all uppercase names with words separated by underscores.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126055


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220418|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2014-01-06 09:49:38 PST ---
(From update of attachment 220418)
View in context: https://bugs.webkit.org/attachment.cgi?id=220418&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2726
> +        if not match(r'^[A-Z_]+$', name):

This expression doesn't allow for digits, which may be legitimately present in macro names.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.